Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only trigger arrow CI on changes to arrow #2227

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 29, 2022

Which issue does this PR close?

re #2149

Rationale for this change

We should only trigger arrow tests if there were changes to arrow (as it does not depend on any other crates in this workspace)

Somehow I missed this in #2213

I noticed this when I saw the arrow jobs run on #2204

What changes are included in this PR?

Only trigger arrow CI jobs when there are changes to arrow (or .github)

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review July 29, 2022 16:55
@codecov-commenter
Copy link

Codecov Report

Merging #2227 (db26326) into master (393f006) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2227      +/-   ##
==========================================
- Coverage   82.52%   82.52%   -0.01%     
==========================================
  Files         240      240              
  Lines       62267    62267              
==========================================
- Hits        51387    51386       -1     
- Misses      10880    10881       +1     
Impacted Files Coverage Δ
parquet_derive/src/parquet_field.rs 65.53% <0.00%> (-0.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tustvold tustvold merged commit bedeb4f into apache:master Jul 29, 2022
@ursabot
Copy link

ursabot commented Jul 29, 2022

Benchmark runs are scheduled for baseline = 561b14c and contender = bedeb4f. bedeb4f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants