Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move FixedSizeBinaryArray to array_fixed_size_binary.rs #2218

Merged
merged 2 commits into from
Jul 30, 2022

Conversation

HaoYang670
Copy link
Contributor

@HaoYang670 HaoYang670 commented Jul 29, 2022

Signed-off-by: remzi [email protected]

Which issue does this PR close?

None. This is a subtask of #2217.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Signed-off-by: remzi <[email protected]>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 29, 2022
Signed-off-by: remzi <[email protected]>
@HaoYang670 HaoYang670 changed the title Move FixedSizeBinaryArray to array_fixed_binary.rs Move FixedSizeBinaryArray to array_fixed_size_binary.rs Jul 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2218 (425e158) into master (acd8042) will decrease coverage by 0.00%.
The diff coverage is 89.87%.

@@            Coverage Diff             @@
##           master    #2218      +/-   ##
==========================================
- Coverage   82.53%   82.53%   -0.01%     
==========================================
  Files         239      240       +1     
  Lines       62299    62299              
==========================================
- Hits        51417    51416       -1     
- Misses      10882    10883       +1     
Impacted Files Coverage Δ
arrow/src/array/mod.rs 100.00% <ø> (ø)
arrow/src/array/array_binary.rs 94.80% <75.00%> (+1.93%) ⬆️
arrow/src/array/array_fixed_size_binary.rs 90.37% <90.37%> (ø)
parquet/src/encodings/encoding.rs 93.43% <0.00%> (-0.20%) ⬇️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tustvold tustvold merged commit f41fb1c into apache:master Jul 30, 2022
@ursabot
Copy link

ursabot commented Jul 30, 2022

Benchmark runs are scheduled for baseline = ca43719 and contender = f41fb1c. f41fb1c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@HaoYang670 HaoYang670 deleted the move_fixed_binary branch July 31, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants