-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change builder append
methods to be infallible where possible
#2103
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2103 +/- ##
=======================================
Coverage 83.73% 83.74%
=======================================
Files 225 225
Lines 59412 59401 -11
=======================================
- Hits 49748 49743 -5
+ Misses 9664 9658 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks
Benchmark runs are scheduled for baseline = b2cf02c and contender = 8d7e2ae. 8d7e2ae is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
append
methods to be infallible where possible
Which issue does this PR close?
Closes #2071.
Rationale for this change
Infallible methods are easier to use and less confusing when there are no actual error cases.
What changes are included in this PR?
Nearly all append methods in builders are now infallible. The following builders still have fallible methods
Are there any user-facing changes?
Yes, a lot of them