Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Fix clippy error after updating rust toolchain #1984

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Jun 30, 2022

Which issue does this PR close?

There are a few clippy errors on CI (e.g. https://github.com/apache/arrow-rs/runs/7140900792?check_suite_focus=true). I can reproduce it once do rustup update locally.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate labels Jun 30, 2022
@viirya
Copy link
Member Author

viirya commented Jun 30, 2022

cc @sunchao @tustvold

Copy link
Contributor

@HaoYang670 HaoYang670 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I have no right to merge this. We need an approval from a maintainer.

@viirya
Copy link
Member Author

viirya commented Jul 1, 2022

cc @alamb too

Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya

@viirya
Copy link
Member Author

viirya commented Jul 1, 2022

Thank you @liukun4515 @HaoYang670

@viirya viirya merged commit ccddaa8 into apache:master Jul 1, 2022
@tustvold tustvold mentioned this pull request Jul 3, 2022
MazterQyou pushed a commit to cube-js/arrow-rs that referenced this pull request Jul 13, 2022
MazterQyou pushed a commit to cube-js/arrow-rs that referenced this pull request Aug 4, 2022
ovr pushed a commit to cube-js/arrow-rs that referenced this pull request Aug 15, 2022
mcheshkov pushed a commit to cube-js/arrow-rs that referenced this pull request Aug 21, 2024
Can drop this after rebase on commit ccddaa8 "Fix clippy (apache#1984)", first released in 18.0.0
mcheshkov pushed a commit to cube-js/arrow-rs that referenced this pull request Aug 21, 2024
Can drop this after rebase on commit ccddaa8 "Fix clippy (apache#1984)", first released in 18.0.0
mcheshkov pushed a commit to cube-js/arrow-rs that referenced this pull request Aug 21, 2024
Can drop this after rebase on commit ccddaa8 "Fix clippy (apache#1984)", first released in 18.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants