-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Fix clippy error after updating rust toolchain #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
Changes to the arrow crate
arrow-flight
Changes to the arrow-flight crate
parquet
Changes to the parquet crate
labels
Jun 30, 2022
HaoYang670
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I have no right to merge this. We need an approval from a maintainer.
cc @alamb too |
liukun4515
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @viirya
Thank you @liukun4515 @HaoYang670 |
Closed
MazterQyou
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Jul 13, 2022
MazterQyou
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 4, 2022
ovr
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 15, 2022
mcheshkov
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 21, 2024
Can drop this after rebase on commit ccddaa8 "Fix clippy (apache#1984)", first released in 18.0.0
mcheshkov
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 21, 2024
Can drop this after rebase on commit ccddaa8 "Fix clippy (apache#1984)", first released in 18.0.0
mcheshkov
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 21, 2024
Can drop this after rebase on commit ccddaa8 "Fix clippy (apache#1984)", first released in 18.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
arrow
Changes to the arrow crate
arrow-flight
Changes to the arrow-flight crate
parquet
Changes to the parquet crate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
There are a few clippy errors on CI (e.g. https://github.com/apache/arrow-rs/runs/7140900792?check_suite_focus=true). I can reproduce it once do
rustup update
locally.Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?