Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add parquet-fromcsv (#1) #1798

Merged
merged 14 commits into from
Jun 10, 2022
Merged

add parquet-fromcsv (#1) #1798

merged 14 commits into from
Jun 10, 2022

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented Jun 6, 2022

add command line tool for convert csv to parquet.

Which issue does this PR close?

Closes #1797 .

Rationale for this change

What changes are included in this PR?

add parquet-fromcsv CLI,

Are there any user-facing changes?

@kazuk
add parquet-fromcsv (#1)
cdf3657 
add command line tool for convert csv to parquet.
@github-actions github-actions bot added the parquet Changes to the parquet crate label Jun 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022 •
edited
Loading

Codecov Report

Merging #1798 (312a596) into master (db41b33) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1798      +/-   ##
==========================================
- Coverage   83.53%   83.48%   -0.06%     
==========================================
  Files         200      201       +1     
  Lines       56798    56838      +40     
==========================================
+ Hits        47449    47451       +2     
- Misses       9349     9387      +38
Impacted Files Coverage Δ
parquet/src/bin/parquet-fromcsv.rs 0.00% <0.00%> (ø)
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db41b33...312a596. Read the comment docs.

@tustvold
Copy link
Contributor

tustvold commented Jun 7, 2022

Sorry for the delay, I keep meaning to review this, will endeavor to do so tomorrow

tustvold
tustvold approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice, only some relatively minor nits.

parquet/src/bin/parquet-fromcsv.rs Outdated Show resolved Hide resolved
parquet/src/bin/parquet-fromcsv.rs Show resolved Hide resolved
parquet/src/bin/parquet-fromcsv.rs Show resolved Hide resolved
parquet/src/bin/parquet-fromcsv.rs Outdated Show resolved Hide resolved
parquet/src/bin/parquet-fromcsv.rs Outdated Show resolved Hide resolved
parquet/src/bin/parquet-fromcsv.rs Outdated Show resolved Hide resolved
parquet/src/bin/parquet-fromcsv.rs Outdated Show resolved Hide resolved
parquet/src/bin/parquet-fromcsv.rs Outdated Show resolved Hide resolved
parquet/src/bin/parquet-fromcsv.rs Outdated Show resolved Hide resolved
parquet/Cargo.toml Outdated Show resolved Hide resolved
@kazuk kazuk requested review from alamb and tustvold June 10, 2022 05:08
@tustvold
Copy link
Contributor

Wonderful, thank you for this 🏅

The MIRI failures are unrelated to this PR so going to get this in 😄

@tustvold tustvold merged commit bd33489 into apache:master Jun 10, 2022
@alamb
Copy link
Contributor

alamb commented Jun 10, 2022

Thanks @kazuk and @tustvold 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

@alamb alamb Awaiting requested review from alamb

Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command line tool for convert CSV to Parquet
4 participants
@kazuk @codecov-commenter @tustvold @alamb