Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ChunkReader for Bytes, deprecate SliceableCursor #1775

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Jun 2, 2022

Deprecate SliceableCursor

Which issue does this PR close?

Part of #1163
Part of #1474

Rationale for this change

Better ecosystem interoperability, removes custom code, and may eventually allow eliding copies on read.

What changes are included in this PR?

Implement ChunkReader for Bytes and deprecates SliceableCursor

Are there any user-facing changes?

Deprecates an API

Deprecate SliceableCursor
@github-actions github-actions bot added the parquet Changes to the parquet crate label Jun 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1775 (6f8b935) into master (c1a91dc) will decrease coverage by 0.01%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master    #1775      +/-   ##
==========================================
- Coverage   83.39%   83.38%   -0.02%     
==========================================
  Files         198      198              
  Lines       56142    56148       +6     
==========================================
- Hits        46821    46818       -3     
- Misses       9321     9330       +9     
Impacted Files Coverage Δ
parquet/src/util/cursor.rs 62.18% <ø> (-1.69%) ⬇️
parquet/src/file/serialized_reader.rs 94.46% <75.00%> (-1.17%) ⬇️
parquet/src/arrow/arrow_reader.rs 96.13% <100.00%> (ø)
parquet/src/arrow/arrow_writer.rs 97.77% <100.00%> (ø)
parquet/src/file/footer.rs 95.37% <100.00%> (ø)
parquet/src/file/writer.rs 92.84% <100.00%> (-0.02%) ⬇️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.46%) ⬇️
arrow/src/datatypes/datatype.rs 65.79% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1a91dc...6f8b935. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is heading (less custom stuff in parquet-rs) 👍

@@ -26,13 +26,15 @@ use std::{cmp, fmt};
/// because the lack of Generic Associated Type implies that you would require complex lifetime propagation when
/// returning such a cursor.
#[allow(clippy::rc_buffer)]
#[deprecated = "use bytes::Bytes instead"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit eb706b7 into apache:master Jun 3, 2022
@alamb alamb changed the title Implement ChunkReader for Bytes Implement ChunkReader for Bytes, deprecate SliceableCursor Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants