Simplify ParquetFileArrowReader Metadata API #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1773 +/- ##
==========================================
- Coverage 83.39% 83.39% -0.01%
==========================================
Files 198 198
Lines 56138 56142 +4
==========================================
- Hits 46819 46818 -1
- Misses 9319 9324 +5
Continue to review full report at Codecov.
|
alamb
approved these changes
Jun 1, 2022
| @@ -164,10 +165,21 @@ impl ParquetFileArrowReader { | |||
| } | |||
|
|
|||
| /// Expose the reader metadata | |||
| #[deprecated = "use metadata() instead"] | |||
There was a problem hiding this comment.
👍 love deprecated -- first step towards keeping the API stable for longer 👍
|
Thank you @tustvold |
nevi-me
approved these changes
Jun 1, 2022
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on from #1716
Rationale for this change
As pointed out by @alamb https://github.com/influxdata/influxdb_iox/pull/4743/files/5fccaab1f94f7e5b8b69ab35ea11c151cb1b8a2d#r885642739 the UX of getting the parquet schema from a ParquetFileArrowReader is not great.
What changes are included in this PR?
Adds a parquet_schema member function that returns the schema.
It also deprecates the get_metadata function, as it doesn't need a mutable reference nor to return a clone, and replaces it with a
metadatafunction that is consistent with the equivalent method on FileReader.Are there any user-facing changes?
A function is deprecated