Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive schema from flight data #1670

Merged
merged 2 commits into from
May 8, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented May 7, 2022

Which issue does this PR close?

Closes #1669.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@viirya viirya force-pushed the fix_ipc_nested_dict_flight branch from 5066ebf to 513389d Compare May 7, 2022 19:14
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #1670 (3628b43) into master (f74ad34) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1670      +/-   ##
==========================================
- Coverage   83.11%   83.10%   -0.01%     
==========================================
  Files         193      193              
  Lines       55875    55881       +6     
==========================================
+ Hits        46439    46441       +2     
- Misses       9436     9440       +4     
Impacted Files Coverage Δ
...ng/src/flight_client_scenarios/integration_test.rs 0.00% <0.00%> (ø)
arrow/src/array/transform/mod.rs 86.80% <0.00%> (+0.11%) ⬆️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74ad34...3628b43. Read the comment docs.

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

I do wonder if we should provide a flight client abstraction to hide these edge-cases from unsuspecting users, including ourselves 😄

@viirya
Copy link
Member Author

viirya commented May 8, 2022

I hope this is the only issue we need to deal with.

@tustvold tustvold merged commit 03ab9a3 into apache:master May 8, 2022
@viirya
Copy link
Member Author

viirya commented May 8, 2022

Thank you @tustvold !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flight_client_scenarios integration test should receive schema from flight data
3 participants