-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove StringOffsetTrait
and BinaryOffsetTrait
#1645
Conversation
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1645 +/- ##
=======================================
Coverage 83.02% 83.03%
=======================================
Files 193 193
Lines 55612 55622 +10
=======================================
+ Hits 46174 46184 +10
Misses 9438 9438
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, why don't we just make a const
is_large
in OffsetSizeTrait
simply?
pub trait OffsetSizeTrait {
const IS_LARGE: bool;
}
impl OffsetSizeTrait for i32 {
const IS_LARGE: bool = false;
}
impl OffsetSizeTrait for i64 {
const IS_LARGE: bool = true
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just one question above.
Strongly agree with you! |
Signed-off-by: remzi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit you can take or leave, will merge later today.
Thanks 👍
Going to get this in as the merge conflict potential is high |
arrow 14 is shaping up for another great release 🎉 |
Which issue does this PR close?
Closes #1644.
Rationale for this change
What changes are included in this PR?
StringOffsetTrait
andBinaryOffsetTrait
get_data_type
function forStringArray
andBinaryArray
(unfortunately, this function cannot beconst
becauseOffsetSizeTrait::is_large
is notconst
)Are there any user-facing changes?
Yes. Delete 2 public traits.