Read/write nested dictionary under map in ipc stream reader/writer #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1583 +/- ##
==========================================
+ Coverage 82.87% 82.94% +0.07%
==========================================
Files 193 193
Lines 55304 55411 +107
==========================================
+ Hits 45832 45962 +130
+ Misses 9472 9449 -23
Continue to review full report at Codecov.
|
tustvold
approved these changes
Apr 19, 2022
arrow/src/ipc/reader.rs
Outdated
| @@ -1481,4 +1481,55 @@ mod tests { | |||
| let output_batch = roundtrip_ipc_stream(&input_batch); | |||
| assert_eq!(input_batch, output_batch); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_roundtrip_stream_nested_dict_dict_in_map() { | |||
There was a problem hiding this comment.
Suggested change
| fn test_roundtrip_stream_nested_dict_dict_in_map() { | |
| fn test_roundtrip_stream_nested_dict_of_map_of_dict() { |
arrow/src/ipc/reader.rs
Outdated
| let dict_array = DictionaryArray::<Int8Type>::try_new(&keys, &values).unwrap(); | ||
|
|
||
| let keys_array = Int32Array::from_iter_values([0, 0, 1, 2, 0, 1]); | ||
| let keys_field = Field::new("keys", DataType::Int32, false); |
There was a problem hiding this comment.
Might want to test dictionary encoded keys as well
arrow/src/ipc/reader.rs
Outdated
| let values_field = Field::new_dict( | ||
| "values", | ||
| DataType::Dictionary(Box::new(DataType::Int8), Box::new(DataType::Utf8)), | ||
| false, |
There was a problem hiding this comment.
Could also test some NULLs
|
Thank you @tustvold. Revised based on the suggestions. |
tustvold
reviewed
Apr 20, 2022
tustvold
approved these changes
Apr 20, 2022
|
Thank you @tustvold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1582.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?