Add ArrowReaderOptions to ParquetFileArrowReader, add option to skip decoding arrow metadata from parquet (#1459)
#1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix inference from null logical type (apache#1557) Replace some `&Option<T>` with `Option<&T>` (apache#1556)
tustvold
commented
Apr 13, 2022
| /// Returns the key value metadata, returns `None` if [`ArrowReaderOptions::skip_arrow_metadata`] | ||
| fn get_kv_metadata(&self) -> Option<&Vec<KeyValue>> { | ||
| if self.options.skip_arrow_metadata { | ||
| return None; |
There was a problem hiding this comment.
This can't be written without the change in #1556 to move away from &Option<T>
tustvold
commented
Apr 13, 2022
| @@ -690,6 +690,8 @@ impl ParquetTypeConverter<'_> { | |||
| t.unit | |||
| ))), | |||
| }, | |||
| // https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#unknown-always-null | |||
| (Some(LogicalType::UNKNOWN(_)), _) => Ok(DataType::Null), | |||
There was a problem hiding this comment.
This is the fix for #1557
tustvold
commented
Apr 13, 2022
| assert_eq!(schema.field(0), &arrow_field); | ||
| } | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
This is the closest I could get to a test of #1459 as we always write and decode the LogicalType, even when technically PARQUET_1_0 doesn't support it. The nature of thrift means this isn't actually a bug I don't think
alamb
approved these changes
Apr 14, 2022
Co-authored-by: Andrew Lamb <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1558 +/- ##
==========================================
+ Coverage 82.83% 82.85% +0.02%
==========================================
Files 190 190
Lines 54957 55042 +85
==========================================
+ Hits 45521 45606 +85
Misses 9436 9436
Continue to review full report at Codecov.
|
alamb
changed the title
ArrowReaderOptions to ParquetFileArrowReader, add option to skip decoding arrow metadata from parquet (#1459)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1459
Closes #1557
Part of #1556
Rationale for this change
See tickets
What changes are included in this PR?
See tickets
Are there any user-facing changes?
Yes