Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a diagram to take kernel documentation #1524

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 5, 2022

Which issue does this PR close?

NA

Rationale for this change

I made a diagram for #1523 and figured I would put it in the docs as well

What changes are included in this PR?

add some ascii art to the documentation

Are there any user-facing changes?

docs

@alamb alamb added the documentation Improvements or additions to documentation label Apr 5, 2022
@github-actions github-actions bot added the arrow Changes to the arrow crate label Apr 5, 2022
Copy link
Member

@yjshen yjshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your diagrams are always great to see!

@codecov-commenter
Copy link

Codecov Report

Merging #1524 (eb3b8d3) into master (eb6b7c6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
- Coverage   82.76%   82.75%   -0.01%     
==========================================
  Files         190      190              
  Lines       54702    54702              
==========================================
- Hits        45272    45271       -1     
- Misses       9430     9431       +1     
Impacted Files Coverage Δ
arrow/src/compute/kernels/take.rs 95.41% <ø> (ø)
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6b7c6...eb3b8d3. Read the comment docs.

@alamb alamb merged commit e27a264 into apache:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants