Update `prost`, `prost-derive` and `prost-types` to 0.10, `tonic`, and `tonic-build` to `0.7` #1510

alamb · 2022-03-30T19:49:49Z

Update prost, prost-derive and prost-types to 0.10

Closes #1500
Closes #1501
Closes #1502
Closes #1520
Closes #1521

alamb · 2022-03-30T19:52:49Z

We probably need to wait for a new version of tonic that updates prost: https://crates.io/crates/tonic/0.6.2/dependencies

tustvold · 2022-03-31T10:40:51Z

Yup, ticket to follow is here - hyperium/tonic#946

tustvold · 2022-04-03T18:08:12Z

FYI tonic 0.7 has now been released and updates prost to 0.10

alamb · 2022-04-04T20:10:45Z

I have updated to use tonic and tonic-build 0.7 and checked in the newly generated code

codecov-commenter · 2022-04-04T20:50:15Z

Codecov Report

Merging #1510 (880ffe2) into master (0a625ed) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 880ffe2 differs from pull request most recent head d6f78b1. Consider uploading reports for the commit d6f78b1 to get more accurate results

@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
- Coverage   82.77%   82.74%   -0.04%     
==========================================
  Files         190      190              
  Lines       54689    54711      +22     
==========================================
- Hits        45269    45268       -1     
- Misses       9420     9443      +23

Impacted Files	Coverage Δ
arrow-flight/src/arrow.flight.protocol.rs	`0.00% <0.00%> (ø)`
parquet_derive/src/parquet_field.rs	`65.98% <0.00%> (-0.23%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a625ed...d6f78b1. Read the comment docs.

alamb · 2022-04-05T13:21:48Z

arrow-flight/build.rs

+        let proto_dir = Path::new("../format");
+        let proto_path = Path::new("../format/Flight.proto");
+
+        tonic_build::configure()


Following model in influxdata/pbjson#40 from @tustvold

tustvold · 2022-04-05T13:27:20Z

.github/workflows/rust.yml

@@ -57,7 +57,7 @@ jobs:
      - name: Setup Build Dependencies
        run: |
          apt-get update
-          apt-get install cmake protobuf-compiler
+          apt-get install -y cmake protobuf-compiler


I think you should be able to get away without cmake if you install protobuf-compiler

in 0a87a43

Updates the requirements on [tonic](https://github.com/hyperium/tonic) to permit the latest version. - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/hyperium/tonic/blob/master/CHANGELOG.md) - [Commits](hyperium/tonic@v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: tonic dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>

Updates the requirements on [tonic-build](https://github.com/hyperium/tonic) to permit the latest version. - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/hyperium/tonic/blob/master/CHANGELOG.md) - [Commits](hyperium/tonic@v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: tonic-build dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>

alamb · 2022-04-05T19:41:34Z

.github/actions/setup-builder/action.yaml

+    - name: Install Build Dependencies
+      shell: bash
+      run: |
+        apt-get update


I was trying to avoid copy/pasting this a bunch of times in rust.yaml

alamb · 2022-04-05T19:41:59Z

arrow-flight/src/arrow.flight.protocol.rs

@@ -6,102 +6,101 @@
 pub struct HandshakeRequest {
    ///
    /// A defined protocol version
-    #[prost(uint64, tag = "1")]


I just checked in the generated code

yjshen · 2022-04-07T00:52:48Z

.github/actions/setup-builder/action.yaml

+    required: true
+    default: 'stable'
+runs:
+  using: "composite"


github-actions bot added the arrow-flight Changes to the arrow-flight crate label Mar 30, 2022

This was referenced Mar 31, 2022

Update prost requirement from 0.9 to 0.10 #1500

Closed

Update prost-types requirement from 0.9.0 to 0.10.0 #1501

Closed

Update prost-derive requirement from 0.9 to 0.10 #1502

Closed

alamb changed the title ~~chore: Update prost, prost-derive and prost-types to 0.10~~ chore: Update prost, prost-derive and prost-types to 0.10, tonic, and tonic-build to 0.7 Apr 4, 2022

This was referenced Apr 4, 2022

Update tonic-build requirement from 0.6 to 0.7 #1521

Closed

Update tonic requirement from 0.6 to 0.7 #1520

Closed

alamb commented Apr 5, 2022

View reviewed changes

tustvold reviewed Apr 5, 2022

View reviewed changes

alamb mentioned this pull request Apr 5, 2022

Reduce duplication in github actions rust.yml #1526

Closed

alamb and others added 12 commits April 5, 2022 15:39

chore: Update prost, prost-derive and prost-types to 0.10

8837450

Update generated code

de79bcd

Try installing cmake dependencies for flight

6a6d3b4

install cmake and protobuf

3788239

Use --experimental_allow_proto3_optional flag

d4a9845

fix apt-install

675ed7b

try to install just protobuf compiler

3b48ed7

Add action to configure workspace

f22acab

Use prost enabled toolchain

7842049

fixes

798924b

alamb force-pushed the alamb/update_prost branch from ff1931b to 798924b Compare April 5, 2022 19:40

alamb commented Apr 5, 2022

View reviewed changes

fixups

880ffe2

fix clippy

d6f78b1

This was referenced Apr 5, 2022

Update tonic-build requirement from 0.6 to 0.7 apache/datafusion#2153

Closed

Update tonic requirement from 0.6 to 0.7 apache/datafusion#2154

Closed

alamb marked this pull request as draft April 5, 2022 20:34

alamb marked this pull request as ready for review April 6, 2022 17:58

yjshen approved these changes Apr 7, 2022

View reviewed changes

.github/actions/setup-builder/action.yaml

required: true

default: 'stable'

runs:

using: "composite"

Copy link

Member

yjshen Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

alamb merged commit c7c7af6 into apache:master Apr 7, 2022

alamb added the api-change Changes to the arrow API label Apr 15, 2022

alamb changed the title ~~chore: Update prost, prost-derive and prost-types to 0.10, tonic, and tonic-build to 0.7~~ Update prost, prost-derive and prost-types to 0.10, tonic, and tonic-build to 0.7 Apr 15, 2022

alamb mentioned this pull request Apr 17, 2022

Update to Arrow 12.0.0, update tonic and prost apache/datafusion#2253

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `prost`, `prost-derive` and `prost-types` to 0.10, `tonic`, and `tonic-build` to `0.7` #1510

Update `prost`, `prost-derive` and `prost-types` to 0.10, `tonic`, and `tonic-build` to `0.7` #1510

alamb commented Mar 30, 2022 •

edited

Loading

alamb commented Mar 30, 2022

tustvold commented Mar 31, 2022

tustvold commented Apr 3, 2022

alamb commented Apr 4, 2022

codecov-commenter commented Apr 4, 2022 •

edited

Loading

alamb Apr 5, 2022

tustvold Apr 5, 2022

alamb Apr 5, 2022

alamb Apr 5, 2022

alamb Apr 5, 2022

yjshen Apr 7, 2022

Update prost, prost-derive and prost-types to 0.10, tonic, and tonic-build to 0.7 #1510

Update prost, prost-derive and prost-types to 0.10, tonic, and tonic-build to 0.7 #1510

Conversation

alamb commented Mar 30, 2022 • edited Loading

alamb commented Mar 30, 2022

tustvold commented Mar 31, 2022

tustvold commented Apr 3, 2022

alamb commented Apr 4, 2022

codecov-commenter commented Apr 4, 2022 • edited Loading

Codecov Report

alamb Apr 5, 2022

Choose a reason for hiding this comment

tustvold Apr 5, 2022

Choose a reason for hiding this comment

alamb Apr 5, 2022

Choose a reason for hiding this comment

alamb Apr 5, 2022

Choose a reason for hiding this comment

alamb Apr 5, 2022

Choose a reason for hiding this comment

yjshen Apr 7, 2022

Choose a reason for hiding this comment

Update `prost`, `prost-derive` and `prost-types` to 0.10, `tonic`, and `tonic-build` to `0.7` #1510

Update `prost`, `prost-derive` and `prost-types` to 0.10, `tonic`, and `tonic-build` to `0.7` #1510

alamb commented Mar 30, 2022 •

edited

Loading

codecov-commenter commented Apr 4, 2022 •

edited

Loading