-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default-features = false
for zstd
in the parquet crate to support wasm32-unknown-unknown
#1414
Conversation
Related: #1415 |
I did also have to add Is the failing integration test CI run related to this? |
Version 0.11.0 is missing the shim header files for wasm support. I updated the Now the parquet crate builds with
(after adding |
I was made aware that bumping to |
default-features = false
for zstd
in the parquet crate to support wasm32-unknown-unknown
Putting |
Codecov Report
@@ Coverage Diff @@
## master #1414 +/- ##
=======================================
Coverage 82.67% 82.67%
=======================================
Files 185 185
Lines 53866 53866
=======================================
Hits 44535 44535
Misses 9331 9331
Continue to review full report at Codecov.
|
Thanks @kylebarron |
Which issue does this PR close?
Relevant to #180 but does not fully close it, as LZ4 still does not build on
wasm32-unknown-unknown
.Rationale for this change
wasm32-unknown-unknown
) support zstd-sys: impl wasm32-unknown-unknown support gyscos/zstd-rs#139.wasm32-unknown-unknown
only withdefault-features = false
What changes are included in this PR?
Add
default-features = false
to the zstd dependency.Are there any user-facing changes?
None