Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note in contributing guideline about types of contributions #1396

Merged
merged 3 commits into from
Mar 6, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 3, 2022

As the community grows, I am trying to help it scale and not be bottlenecked on review by the maintainers.

Ideally by the time one of the maintainers sees a PR it is more or less ready to go (though maybe that is wishful thinking)

Rendered version here: https://github.com/alamb/arrow-rs/blob/alamb/review_plea/CONTRIBUTING.md

@alamb alamb added development-process Related to development process of arrow-rs documentation Improvements or additions to documentation labels Mar 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #1396 (545377c) into master (ab41c25) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1396      +/-   ##
==========================================
- Coverage   83.10%   83.10%   -0.01%     
==========================================
  Files         181      181              
  Lines       53244    53244              
==========================================
- Hits        44247    44246       -1     
- Misses       8997     8998       +1     
Impacted Files Coverage Δ
arrow/src/array/transform/mod.rs 86.20% <0.00%> (-0.23%) ⬇️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab41c25...545377c. Read the comment docs.

@alamb alamb merged commit 1efd81d into apache:master Mar 6, 2022
@alamb alamb deleted the alamb/review_plea branch March 6, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants