Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify release instructions about when to merge CHANGELOG update #1370

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 28, 2022

Which issue does this PR close?

Re #1304

Rationale for this change

It was not 100% clear when releasing arrow when the CHANGELOG update PR should be merged. See #1325 (review)

What changes are included in this PR?

Make it clear the CHANGELOG PR should be merged prior to creating the release candidate

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of arrow-rs label Feb 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1370 (42f3e38) into master (5737449) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 42f3e38 differs from pull request most recent head 99d6fb6. Consider uploading reports for the commit 99d6fb6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1370      +/-   ##
==========================================
- Coverage   82.98%   82.98%   -0.01%     
==========================================
  Files         181      181              
  Lines       52932    52932              
==========================================
- Hits        43925    43924       -1     
- Misses       9007     9008       +1     
Impacted Files Coverage Δ
arrow/src/datatypes/field.rs 53.79% <0.00%> (-0.31%) ⬇️
arrow/src/array/transform/mod.rs 84.39% <0.00%> (-0.14%) ⬇️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5737449...99d6fb6. Read the comment docs.

@alamb
Copy link
Contributor Author

alamb commented Mar 3, 2022

fyi @nevi-me and @houqp

@alamb alamb merged commit ca42869 into apache:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants