Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs examples for dynamically compare functions #1250

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi [email protected]

Which issue does this PR close?

Closes #1202.

Rationale for this change

Make it easier for users to understand and use dyn compare functions.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 30, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1250 (bd29a98) into master (02573e9) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1250      +/-   ##
==========================================
+ Coverage   82.95%   82.96%   +0.01%     
==========================================
  Files         178      178              
  Lines       51522    51547      +25     
==========================================
+ Hits        42740    42766      +26     
+ Misses       8782     8781       -1     
Impacted Files Coverage Δ
arrow/src/compute/kernels/comparison.rs 91.70% <ø> (ø)
arrow/src/array/transform/mod.rs 84.64% <0.00%> (-0.13%) ⬇️
parquet/src/arrow/array_reader.rs 78.21% <0.00%> (+0.01%) ⬆️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.22%) ⬆️
parquet/src/arrow/arrow_reader.rs 93.57% <0.00%> (+0.38%) ⬆️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02573e9...bd29a98. Read the comment docs.

@alamb alamb added the documentation Improvements or additions to documentation label Jan 31, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HaoYang670 -- looks great

@alamb alamb merged commit 90b7969 into apache:master Jan 31, 2022
@HaoYang670 HaoYang670 deleted the add_docs_examples_for_dyn_compare_fns branch January 31, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add doc examples for eq_dyn etc.
3 participants