Add Rust Docs examples for UnionArray #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: remzi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1241 +/- ##
==========================================
- Coverage 82.94% 82.94% -0.01%
==========================================
Files 178 178
Lines 51420 51420
==========================================
- Hits 42651 42650 -1
- Misses 8769 8770 +1
Continue to review full report at Codecov.
|
alamb
approved these changes
Jan 26, 2022
| /// None, | ||
| /// ).unwrap(); | ||
| /// | ||
| /// let value = array.value(0).as_any().downcast_ref::<Int32Array>().unwrap().value(0); |
There was a problem hiding this comment.
It isn't the nicest API in the world, is it ?
However, documenting what we have is 👍
Thank you @HaoYang670
|
thank you @HaoYang670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi [email protected]
Which issue does this PR close?
Closes #751
Rationale for this change
Add 2 docs examples of building
UnionArrayusing the functionUnionArray::try_new,so that users can easily understand the data structure of
UnionArray.What changes are included in this PR?
Are there any user-facing changes?