Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add from_iter_values for binary array #1188

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Add from_iter_values for binary array #1188

merged 1 commit into from
Jan 17, 2022

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jan 17, 2022 •
edited
Loading

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

note the implementation is mirrored from string array

Are there any user-facing changes?

added API for generic binary array

@jimexist jimexist mentioned this pull request Jan 17, 2022
Merged
@codecov-commenter
Copy link

Codecov Report

Merging #1188 (4ae1e50) into master (e45d118) will decrease coverage by 0.00%.
The diff coverage is 89.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1188      +/-   ##
==========================================
- Coverage   82.64%   82.64%   -0.01%     
==========================================
  Files         173      173              
  Lines       50865    50874       +9     
==========================================
+ Hits        42037    42044       +7     
- Misses       8828     8830       +2
Impacted Files Coverage Δ
arrow/src/array/array_string.rs 97.61% <66.66%> (ø)
arrow/src/array/array_binary.rs 93.13% <92.30%> (-0.42%) ⬇️
arrow/src/array/transform/mod.rs 85.43% <0.00%> (-0.14%) ⬇️
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e45d118...4ae1e50. Read the comment docs.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 17, 2022
alamb
alamb approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimexist

arrow/src/array/array_binary.rs
}

// iterator size hint may not be correct so compute the actual number of offsets
assert!(!offsets.is_empty()); // wrote at least one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit d9f574e into master Jan 17, 2022
@jimexist jimexist deleted the add-from-iter-values-for-bin-array branch January 17, 2022 15:40
@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label Jan 20, 2022
@alamb alamb changed the title add from_iter_values for binary array Add from_iter_values for binary array Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimexist @codecov-commenter @alamb