Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize i128 as JSON string #1175

Merged
merged 2 commits into from
Jan 15, 2022
Merged

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #1174

Rationale for this change

See ticket

What changes are included in this PR?

This changes i128 to be JSON serialized as a string

Are there any user-facing changes?

I think so, I'm not very familiar with arrow's JSON interface nor what it is used for

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 14, 2022
Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tustvold . I think there are couple other unit tests that need to be updated.

@tustvold
Copy link
Contributor Author

tustvold commented Jan 14, 2022

The failures seem unrelated to my change, and I'm struggling to reproduce them locally...

Edit: Huzzah, updating to rust toolchain 1.58 can reproduce 🤔

@codecov-commenter
Copy link

Codecov Report

Merging #1175 (f58c4c0) into master (66b84f3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1175   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         173      173           
  Lines       50902    50902           
=======================================
+ Hits        42077    42078    +1     
+ Misses       8825     8824    -1     
Impacted Files Coverage Δ
arrow/src/datatypes/mod.rs 100.00% <100.00%> (ø)
arrow/src/datatypes/native.rs 66.66% <100.00%> (ø)
arrow/src/datatypes/datatype.rs 66.38% <0.00%> (-0.43%) ⬇️
arrow/src/array/transform/mod.rs 85.43% <0.00%> (-0.14%) ⬇️
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️
parquet_derive/src/parquet_field.rs 66.43% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b84f3...f58c4c0. Read the comment docs.

@alamb alamb merged commit 1626b80 into apache:master Jan 15, 2022
@alamb
Copy link
Contributor

alamb commented Jan 15, 2022

Thanks @tustvold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable serde_json arbitrary_precision feature flag
4 participants