Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move simd right out of for_each loop #1150

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Conversation

viirya
Copy link
Member

@viirya viirya commented Jan 10, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

For the scalar part of simd array and scalar operation, we don't need to initiate a vector for the scalar every time.

What changes are included in this PR?

Move scalar part out of for_each loop in simd operation between array and scalar.

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1150 (fc1e998) into master (719096b) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1150   +/-   ##
=======================================
  Coverage   82.55%   82.56%           
=======================================
  Files         169      169           
  Lines       50456    50497   +41     
=======================================
+ Hits        41655    41691   +36     
- Misses       8801     8806    +5     
Impacted Files Coverage Δ
arrow/src/compute/kernels/arithmetic.rs 84.14% <ø> (ø)
arrow/src/datatypes/datatype.rs 66.38% <0.00%> (-0.43%) ⬇️
arrow/src/datatypes/field.rs 53.79% <0.00%> (-0.31%) ⬇️
arrow/src/array/transform/mod.rs 85.43% <0.00%> (-0.27%) ⬇️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (-0.23%) ⬇️
parquet/src/compression.rs 88.59% <0.00%> (ø)
parquet/src/arrow/arrow_writer.rs 98.07% <0.00%> (ø)
arrow/src/compute/kernels/comparison.rs 91.96% <0.00%> (ø)
arrow/src/array/array_string.rs 97.40% <0.00%> (+0.32%) ⬆️
arrow/src/util/test_util.rs 92.04% <0.00%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719096b...fc1e998. Read the comment docs.

@jhorstmann
Copy link
Contributor

Probably doesn't change the performance since the compiler would do this automatically, but makes the inner loop a bit easier to read 👍

@alamb alamb merged commit fee9a9c into apache:master Jan 11, 2022
@alamb
Copy link
Contributor

alamb commented Jan 11, 2022

Thank you for the contribution @viirya and the reviews @jhorstmann and @houqp ❤️

@viirya
Copy link
Member Author

viirya commented Jan 11, 2022

Thank you @houqp @jhorstmann @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants