Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document safety justification of some uses of from_trusted_len_iter #1148

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 9, 2022

Which issue does this PR close?

Re #197

Rationale for this change

As part of #197 I reviewed all uses of from_trusted_len_iter; While doing so I found some without a safety justification, and so I added the results of my review as comments

What changes are included in this PR?

Code comments justifying why (existing) calls to from_trusted_len_iter() are sound

Are there any user-facing changes?

No

@alamb alamb added the documentation Improvements or additions to documentation label Jan 9, 2022
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1148 (2984b99) into master (719096b) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
- Coverage   82.55%   82.55%   -0.01%     
==========================================
  Files         169      169              
  Lines       50456    50456              
==========================================
- Hits        41655    41654       -1     
- Misses       8801     8802       +1     
Impacted Files Coverage Δ
arrow/src/array/array_primitive.rs 94.66% <ø> (ø)
arrow/src/buffer/ops.rs 96.77% <ø> (ø)
arrow/src/compute/kernels/arithmetic.rs 84.14% <ø> (ø)
arrow/src/compute/kernels/length.rs 100.00% <ø> (ø)
parquet/src/encodings/encoding.rs 93.52% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719096b...2984b99. Read the comment docs.

@jhorstmann
Copy link
Contributor

LGTM 🚀

@alamb alamb merged commit f085647 into apache:master Jan 11, 2022
@alamb alamb deleted the alamb/annotate_unsafe branch January 11, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants