Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dyn comparison of interval arrays (#1106) #1107

Merged
merged 5 commits into from
Jan 6, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Dec 29, 2021

Which issue does this PR close?

Closes #1106.

Rationale for this change

See ticket

What changes are included in this PR?

See ticket

Are there any user-facing changes?

Dyn comparison kernels work with interval arrays

@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #1107 (ae70a7d) into master (430bdd4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1107      +/-   ##
==========================================
+ Coverage   82.39%   82.40%   +0.01%     
==========================================
  Files         169      169              
  Lines       50290    50318      +28     
==========================================
+ Hits        41436    41465      +29     
+ Misses       8854     8853       -1     
Impacted Files Coverage Δ
arrow/src/compute/kernels/comparison.rs 89.98% <100.00%> (+0.23%) ⬆️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (ø)
arrow/src/datatypes/field.rs 54.10% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 430bdd4...ae70a7d. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tustvold -- looks good to me 👍

I think the PR has conflicts that need to be resolved as well

@alamb
Copy link
Contributor

alamb commented Jan 5, 2022

@tustvold I took the liberty of merging this PR from master -- will merge when the CI has passed

@alamb alamb merged commit bdbc652 into apache:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interval Support in Dyn Comparison Kernels
3 participants