Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take kernel doesn't handle nulls and structs correctly #530

Closed
bjchambers opened this issue Jul 9, 2021 · 0 comments · Fixed by #531
Closed

Take kernel doesn't handle nulls and structs correctly #530

bjchambers opened this issue Jul 9, 2021 · 0 comments · Fixed by #531
Labels
arrow Changes to the arrow crate bug

Comments

@bjchambers
Copy link
Contributor

Describe the bug

Applying the Take kernel to an array of indices and an array of structs I expect nulls in the output in two cases:

  1. If the index is null for the current row
  2. If the struct is null at the index specified in the current row.

Neither of these cases produce a null value.

To Reproduce

See PR.

Expected behavior

See description / PR.

Additional context

See description / PR.
@bjchambers bjchambers added the bug label Jul 9, 2021
bjchambers added a commit to bjchambers/arrow-rs that referenced this issue Jul 9, 2021
@bjchambers
fix take kernel null handling on structs
4342d28 
This closes apache#530.
@bjchambers bjchambers mentioned this issue Jul 9, 2021
Merged
@alamb alamb closed this as completed in #531 Jul 9, 2021
alamb pushed a commit that referenced this issue Jul 9, 2021
@bjchambers
fix take kernel null handling on structs (#531)
f1fb2b1 
This closes #530.

Co-authored-by: Ben Chambers <[email protected]>
@alamb alamb added the arrow Changes to the arrow crate label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix take kernel null handling on structs bjchambers/arrow-rs
2 participants
@bjchambers @alamb