Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return ETag and Version on Put #4934

Closed
tustvold opened this issue Oct 13, 2023 · 1 comment · Fixed by #4944
Closed

Return ETag and Version on Put #4934

tustvold opened this issue Oct 13, 2023 · 1 comment · Fixed by #4944
Assignees
@tustvold
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface

Comments

@tustvold
Copy link
Contributor

tustvold commented Oct 13, 2023 •
edited
Loading

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Combined with #4925 and #4879 this will provide a complete interface for implementing transactions and snapshotting on object stores.

Describe the solution you'd like

We could return ObjectMeta, however, many stores do not return the last modified time on write and so this might not be a good idea. Perhaps we could return a PutResult structure or something similar 🤔

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Oct 13, 2023
@tustvold tustvold self-assigned this Oct 13, 2023
tustvold added a commit to tustvold/arrow-rs that referenced this issue Oct 17, 2023
@tustvold
Return ETag from ObjectStore::put (apache#4934)
86d2eab
tustvold added a commit to tustvold/arrow-rs that referenced this issue Oct 17, 2023
@tustvold
Return ETag from ObjectStore::put (apache#4934)
3d8c30b
@tustvold tustvold mentioned this issue Oct 17, 2023
Merged
tustvold added a commit that referenced this issue Oct 19, 2023
@tustvold
Return PutResult with an ETag from ObjectStore::put (#4934) (#4944)
4cca029 
* Return ETag from ObjectStore::put (#4934)

* Further tests

* Clippy

* Review feedback
@tustvold tustvold added the object-store Object Store Interface label Nov 2, 2023
@tustvold
Copy link
Contributor Author

tustvold commented Nov 2, 2023

label_issue.py automatically added labels {'object-store'} from #4944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return PutResult with an ETag from ObjectStore::put (#4934) tustvold/arrow-rs
1 participant
@tustvold