Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Date - Date kernel #4383

Closed
Tracked by #5753
alamb opened this issue Jun 7, 2023 · 3 comments · Fixed by #4504
Closed
Tracked by #5753

Support Date - Date kernel #4383

alamb opened this issue Jun 7, 2023 · 3 comments · Fixed by #4504
Assignees
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Jun 7, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
While implementing date/time arithmetic in DataFusion (apache/datafusion#6578) @jackwener found lack of Date - Date support in arithmetic kernels

Describe the solution you'd like
I would like kernels that can subtract

  1. Date32Array - Date32Array and produce an IntervalYearMonthArray
  2. Date64Array - Date64Array and produce IntervalMonthDayNanoArray

Describe alternatives you've considered

Additional context

@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label Jun 7, 2023
@alamb alamb added the arrow Changes to the arrow crate label Jun 7, 2023
@tustvold
Copy link
Contributor

tustvold commented Jun 7, 2023

This likely overlaps with #3999

@sum12
Copy link
Contributor

sum12 commented Jul 5, 2023

was planning to give this a try

Date32Array - Date32Array and produce an IntervalYearMonthArray

iiuc IntervalYearMonthArray cannot represent interval in of 1 day, for example. How about IntervalDayTimeType with millis set to 0.

@tustvold
Copy link
Contributor

tustvold commented Jul 5, 2023

Thank you for expressing interest but I intend to implement this after #4465 which replaces the current arithmetic kernels. It will also return Duration to be consistent with the logic for timestamps, and avoid the issues inherent with intervals

@tustvold tustvold self-assigned this Jul 5, 2023
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jul 10, 2023
tustvold added a commit that referenced this issue Jul 12, 2023
* Support Date - Date (#4383)

* Review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants