Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flight Client should accept fallible streams (do_put and do_exchange) #3462

Closed
alamb opened this issue Jan 5, 2023 · 4 comments · Fixed by #5698
Closed

Flight Client should accept fallible streams (do_put and do_exchange) #3462

alamb opened this issue Jan 5, 2023 · 4 comments · Fixed by #5698
Labels
arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Jan 5, 2023 

    Perhaps this should accept a `Stream<Item=Result<FlightData>>`, otherwise I'm not sure how one could use this to stream a fallible computation without panicking?

Originally posted by @tustvold in #3402 (comment)
This was referenced Jan 5, 2023
Merged
Merged
@alamb alamb changed the title Flight Client should accept fallible streams Flight Client should accept fallible streams (do_put and do_exchange) Feb 23, 2023
@alamb
Copy link
Contributor Author

alamb commented Feb 23, 2023

Update is that we implemented this for do_put here: #3464

What is needed to close this ticket is to apply the same pattern to do_exchange

Since the pattern and testing framework are all in place, I think this would be a good first project.

@alamb alamb added good first issue Good for newcomers arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog labels Feb 23, 2023
@alamb alamb self-assigned this Feb 27, 2023
@alamb alamb removed their assignment Jan 12, 2024
@shourya5
Copy link

So this is repeating the pattern of do_put for do_exchange, right? Is the same for the test case? if so I can take it

@alamb
Copy link
Contributor Author

alamb commented Jan 29, 2024

So this is repeating the pattern of do_put for do_exchange, right? Is the same for the test case? if so I can take it

That is my understanding -- thank you @shourya5

Please ping me on the PR and I will review it

@opensourcegeek
Copy link
Contributor

Not sure about the progress of this issue, I'll pick this up for now. Happy to close my MR if it's not needed.

opensourcegeek pushed a commit to opensourcegeek/arrow-rs that referenced this issue Apr 27, 2024
@bitpacker
Fallible stream for arrow-flight do_exchange call (apache#3462)
283a7f1 
Signed-off-by: Praveen Kumar <[email protected]>
@opensourcegeek opensourcegeek mentioned this issue Apr 27, 2024
Merged
opensourcegeek pushed a commit to opensourcegeek/arrow-rs that referenced this issue Apr 27, 2024
@bitpacker
Fallible stream for arrow-flight do_exchange call (apache#3462)
6509de0 
Signed-off-by: Praveen Kumar <[email protected]>
opensourcegeek pushed a commit to opensourcegeek/arrow-rs that referenced this issue Apr 27, 2024
@bitpacker
Fallible stream for arrow-flight do_exchange call (apache#3462)
f9ec823 
Signed-off-by: Praveen Kumar <[email protected]>
opensourcegeek pushed a commit to opensourcegeek/arrow-rs that referenced this issue Apr 27, 2024
@bitpacker
Fallible stream for arrow-flight do_exchange call (apache#3462)
8fe8a63 
Signed-off-by: Praveen Kumar <[email protected]>
opensourcegeek pushed a commit to opensourcegeek/arrow-rs that referenced this issue Apr 28, 2024
@bitpacker
Fallible stream for arrow-flight do_exchange call (apache#3462)
5cf10c2 
Signed-off-by: Praveen Kumar <[email protected]>
tustvold pushed a commit that referenced this issue May 2, 2024
@opensourcegeek @bitpacker
Fallible stream for arrow-flight do_exchange call (#3462) (#5698)
eb2d00b 
Signed-off-by: Praveen Kumar <[email protected]>
Co-authored-by: Praveen Kumar <[email protected]>
@opensourcegeek opensourcegeek mentioned this issue May 6, 2024
Merged
@alamb alamb mentioned this issue May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fallible stream for arrow-flight do_exchange call (#3462) opensourcegeek/arrow-rs
3 participants
@alamb @opensourcegeek @shourya5