Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row Format: Option to detach/own a row #3078

Closed
crepererum opened this issue Nov 10, 2022 · 1 comment · Fixed by #3079
Closed

Row Format: Option to detach/own a row #3078

crepererum opened this issue Nov 10, 2022 · 1 comment · Fixed by #3079
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@crepererum
Copy link
Contributor

crepererum commented Nov 10, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I'm trying to use the arrow format for an DataFusion group operator. For that it would be super helpful do detach/own a row (acting as a group key).

Describe the solution you'd like
Introduce a new type OwnedRow that does not borrow buffer (for that particular row, not the entire buffer) and type but owns it. That new type should support all operations that the original Row has (clone, eq, ord, hash, borrow underlying raw data).

Describe alternatives you've considered
Make Row a copy-on-write type (similar to Cow). However this would introduce an enum-dispatch overhead to every row access and I think it's easier to do this on a type level (since I guess all users know if they own the row or not).

Additional context
-

@crepererum crepererum added the enhancement Any new improvement worthy of a entry in the changelog label Nov 10, 2022
crepererum added a commit to crepererum/arrow-rs that referenced this issue Nov 10, 2022
crepererum added a commit to crepererum/arrow-rs that referenced this issue Nov 10, 2022
tustvold pushed a commit that referenced this issue Nov 10, 2022
@alamb
Copy link
Contributor

alamb commented Nov 11, 2022

label_issue.py automatically added labels {'arrow'} from #3079

@alamb alamb added the arrow Changes to the arrow crate label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants