Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FFI / CDataInterface for Struct Arrays #251

Closed
alamb opened this issue May 3, 2021 · 0 comments · Fixed by #287
Closed

Implement FFI / CDataInterface for Struct Arrays #251

alamb opened this issue May 3, 2021 · 0 comments · Fixed by #287
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented May 3, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Related to full support for Rust FFI (to pass bytes back and forth with other implementations)

Specifically, as reported by Roee Shlomo, when a struct array is passed to the rust FFI implementation, this error is made:

CDataInterface("The datatype \"Struct([Field { ... }])\" is still not supported in Rust implementation")'

Describe the solution you'd like
Implement FFI / CDataInterface for Struct Arrays

Describe alternatives you've considered
TBD

Additional context
See thread in ASF slack: https://the-asf.slack.com/archives/C01QUFS30TD/p1620058016382800
@alamb alamb added arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog labels May 3, 2021
roee88 added a commit to roee88/arrow-rs that referenced this issue May 12, 2021
@roee88
fix: support nested types in FFI
d9404d2 
Ported from https://github.com/jorgecarleitao/arrow2

Fix apache#20
Fix apache#251

Signed-off-by: roee88 <[email protected]>
roee88 added a commit to roee88/arrow-rs that referenced this issue May 12, 2021
@roee88
fix: support nested types in FFI
375f56e 
Ported from https://github.com/jorgecarleitao/arrow2

Fix apache#20
Fix apache#251

Signed-off-by: roee88 <[email protected]>
roee88 added a commit to roee88/arrow-rs that referenced this issue May 12, 2021
@roee88
fix: support nested types in FFI
0974e39 
Ported from https://github.com/jorgecarleitao/arrow2

Fix apache#20
Fix apache#251

Signed-off-by: roee88 <[email protected]>
@roee88 roee88 mentioned this issue May 12, 2021
Merged
alamb pushed a commit that referenced this issue May 17, 2021
@roee88
Fix FFI and add support for Struct type (#287)
c863a2c 
* fix: support nested types in FFI

Ported from https://github.com/jorgecarleitao/arrow2

Fix #20
Fix #251

Signed-off-by: roee88 <[email protected]>

* Removed Clone from FFI_ArrowArray

Signed-off-by: roee88 <[email protected]>

* Add nesting to FFI struct test

Signed-off-by: roee88 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix FFI and add support for Struct type roee88/arrow-rs
1 participant
@alamb