Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object_store: Create explicit test for symlinks #2206

Closed
alamb opened this issue Jul 28, 2022 · 0 comments · Fixed by #2269
Closed

object_store: Create explicit test for symlinks #2206

alamb opened this issue Jul 28, 2022 · 0 comments · Fixed by #2269
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface

Comments

@alamb
Copy link
Contributor

alamb commented Jul 28, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

As described on #2195 (comment) we are currently relying on idiosynchroncies of the MacOS contents of / for coverage of handling broken symlinks.

Describe the solution you'd like
Test that creates symlinks and ensures listing still works

This probably should include good symlinks as well as broken symlinks

Describe alternatives you've considered
N/A
@alamb alamb added enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface labels Jul 28, 2022
@alamb alamb mentioned this issue Jul 28, 2022
Merged
@tustvold tustvold mentioned this issue Jul 28, 2022
Closed
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 1, 2022
@tustvold
Handle symlinks in LocalFileSystem (apache#2206)
8084dc1
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 1, 2022
@tustvold
Handle symlinks in LocalFileSystem (apache#2206)
28ff596
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 1, 2022
@tustvold
Handle symlinks in LocalFileSystem (apache#2206)
20f1853
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 1, 2022
@tustvold
Handle symlinks in LocalFileSystem (apache#2206)
3d96649
@tustvold tustvold mentioned this issue Aug 1, 2022
Merged
alamb added a commit that referenced this issue Aug 2, 2022
@tustvold @alamb
Handle symlinks in LocalFileSystem (#2206) (#2269)
ad65e88 
* Handle symlinks in LocalFileSystem (#2206)

* Update object_store/src/local.rs

Co-authored-by: Andrew Lamb <[email protected]>

Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface
Projects
None yet
Milestone
No milestone
1 participant
@alamb