Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ArrayAccessor and FromIterator in Cast Kernels #2137

Closed
tustvold opened this issue Jul 22, 2022 · 0 comments · Fixed by #2169
Closed

Use ArrayAccessor and FromIterator in Cast Kernels #2137

tustvold opened this issue Jul 22, 2022 · 0 comments · Fixed by #2169
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The cast kernels are currently implemented using macros, and special cased for the various types of array. It would be less code, and easier to maintain if these instead used generics

Describe the solution you'd like

Rework the kernel to instead use a combination of FromIterator and ArrayAccessor instead of macros

Describe alternatives you've considered

We could not do this

Additional context

#2135

@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog help wanted labels Jul 22, 2022
@alamb alamb changed the title Use ArrayAccessor and FromIterator in Cast Kernels Use ArrayAccessor and FromIterator in Cast Kernels Aug 4, 2022
@alamb alamb added the arrow Changes to the arrow crate label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants