Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ArrayAccessor in Comparison Kernels #2135

Closed
tustvold opened this issue Jul 22, 2022 · 1 comment · Fixed by #2157
Closed

Use ArrayAccessor in Comparison Kernels #2135

tustvold opened this issue Jul 22, 2022 · 1 comment · Fixed by #2157
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently the comparison kernels make extensive use of macros, with #2133 it is possible to rework these to instead make use of the ArrayAccessor trait. This should reduce code duplication and make the code easier to read and maintain.

Describe the solution you'd like

Rework the comparison kernels to use ArrayAccessor instead of PrimitiveArray, GenericStringArray, etc...

Describe alternatives you've considered

We could not do this

Additional context
@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog help wanted labels Jul 22, 2022
@tustvold tustvold mentioned this issue Jul 22, 2022
Closed
@viirya
Copy link
Member

viirya commented Jul 22, 2022

I may try to work on this in this weekend.

@tustvold tustvold mentioned this issue Jul 22, 2022
Closed
@viirya viirya mentioned this issue Jul 25, 2022
Merged
@alamb alamb changed the title Use ArrayAccessor in Comparison Kernels Use ArrayAccessor in Comparison Kernels Aug 4, 2022
@alamb alamb added the arrow Changes to the arrow crate label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ArrayAccessor in Comparison Kernels viirya/arrow-rs
3 participants
@viirya @alamb @tustvold