Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose IndexIterator and SlicesIterator on Bitmap #1864

Closed
tustvold opened this issue Jun 13, 2022 · 0 comments
Closed

Expose IndexIterator and SlicesIterator on Bitmap #1864

tustvold opened this issue Jun 13, 2022 · 0 comments
Assignees
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

filter::SlicesIterator and filter::IndexIterator provide very efficient mechanisms to iterate through validity buffers, in some cases yielding order of magnitude improvements over element-wise iteration.

Describe the solution you'd like

Expose the following methods on Bitmap making use of these

fn iter_set_bits(&self, offset: usize) -> impl Iterator<usize> {}

fn iter_set_bit_ranges(&self, offset: usize) -> impl Iterator<(usize, usize)> {}

Describe alternatives you've considered

We could not do this

Additional context

#1802 tracks extending Bitmap with the ability to track an offset

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Jun 13, 2022
@tustvold tustvold self-assigned this Jun 13, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jun 13, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jun 13, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jun 13, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jun 13, 2022
tustvold added a commit that referenced this issue Jun 16, 2022
* Expose BitSliceIterator and BitIndexIterator (#1864)

* Update arrow/src/compute/kernels/filter.rs

Co-authored-by: Andrew Lamb <[email protected]>

* Format

Co-authored-by: Andrew Lamb <[email protected]>
@tustvold tustvold closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

1 participant