Cleanup ArrayData::buffers (#4583)

* Cleanup ArrayData::buffers * Hide from docs * Review feedback
apache · Aug 1, 2023 · a5d9118 · a5d9118
1 parent a2e2fa7
commit a5d9118
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 102 deletions.
diff --git a/arrow-data/src/data/mod.rs → arrow-data/src/data.rs b/arrow-data/src/data/mod.rs → arrow-data/src/data.rs
@@ -29,8 +29,10 @@ use std::sync::Arc;
 
 use crate::equal;
 
-mod buffers;
-pub use buffers::*;
+/// A collection of [`Buffer`]
+#[doc(hidden)]
+#[deprecated(note = "Use [Buffer]")]
+pub type Buffers<'a> = &'a [Buffer];
 
 #[inline]
 pub(crate) fn contains_nulls(
@@ -345,10 +347,9 @@ impl ArrayData {
         &self.data_type
     }
 
-    /// Returns the [`Buffers`] storing data for this [`ArrayData`]
-    pub fn buffers(&self) -> Buffers<'_> {
-        // In future ArrayData won't store data contiguously as `Vec<Buffer>` (#1799)
-        Buffers::from_slice(&self.buffers)
+    /// Returns the [`Buffer`] storing data for this [`ArrayData`]
+    pub fn buffers(&self) -> &[Buffer] {
+        &self.buffers
     }
 
     /// Returns a slice of children [`ArrayData`]. This will be non

diff --git a/arrow-data/src/data/buffers.rs b/arrow-data/src/data/buffers.rs