Skip to content

Commit

Permalink
Automatically retry failed MIRI runs to work around intermittent fail…
Browse files Browse the repository at this point in the history
…ures (#922)

* Move MIRI checks into a shell script

* add retry loop
  • Loading branch information
alamb authored Nov 6, 2021
1 parent bb05b00 commit 62934e9
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 6 deletions.
26 changes: 26 additions & 0 deletions .github/workflows/miri.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
#!/bin/bash
#
# Script
#
# Must be run with nightly rust for example
# rustup default nightly


export MIRIFLAGS="-Zmiri-disable-isolation"
cargo miri setup
cargo clean

run_miri() {
# Currently only the arrow crate is tested with miri
# IO related tests and some unsupported tests are skipped
cargo miri test -p arrow -- --skip csv --skip ipc --skip json
}

# If MIRI fails, automatically retry
# Seems like miri is occasionally killed by the github runner
# https://github.com/apache/arrow-rs/issues/879
for i in `seq 1 5`; do
echo "Starting Arrow MIRI run..."
run_miri && break
echo "foo" > /tmp/data.txt
done
7 changes: 1 addition & 6 deletions .github/workflows/miri.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,4 @@ jobs:
RUST_BACKTRACE: full
RUST_LOG: "trace"
run: |
export MIRIFLAGS="-Zmiri-disable-isolation"
cargo miri setup
cargo clean
# Currently only the arrow crate is tested with miri
# IO related tests and some unsupported tests are skipped
cargo miri test -p arrow -- --skip csv --skip ipc --skip json
bash .github/workflows/miri.sh

0 comments on commit 62934e9

Please sign in to comment.