Skip to content

Commit

Permalink
fix clippy errors in 1.60 (#1527)
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb authored Apr 8, 2022
1 parent 252a983 commit 5f16f92
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions arrow/src/ffi.rs
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ impl Drop for FFI_ArrowSchema {

// returns the number of bits that buffer `i` (in the C data interface) is expected to have.
// This is set by the Arrow specification
#[allow(clippy::manual_bits)]
fn bit_width(data_type: &DataType, i: usize) -> Result<usize> {
Ok(match (data_type, i) {
// the null buffer is bit sized
Expand Down
4 changes: 4 additions & 0 deletions parquet/src/arrow/schema.rs
Original file line number Diff line number Diff line change
Expand Up @@ -662,6 +662,7 @@ impl ParquetTypeConverter<'_> {
}
}

#[allow(clippy::wrong_self_convention)]
fn from_int32(&self) -> Result<DataType> {
match (
self.schema.get_basic_info().logical_type(),
Expand Down Expand Up @@ -707,6 +708,7 @@ impl ParquetTypeConverter<'_> {
}
}

#[allow(clippy::wrong_self_convention)]
fn from_int64(&self) -> Result<DataType> {
match (
self.schema.get_basic_info().logical_type(),
Expand Down Expand Up @@ -758,6 +760,7 @@ impl ParquetTypeConverter<'_> {
}
}

#[allow(clippy::wrong_self_convention)]
fn from_fixed_len_byte_array(&self) -> Result<DataType> {
match (
self.schema.get_basic_info().logical_type(),
Expand Down Expand Up @@ -796,6 +799,7 @@ impl ParquetTypeConverter<'_> {
)
}

#[allow(clippy::wrong_self_convention)]
fn from_byte_array(&self) -> Result<DataType> {
match (self.schema.get_basic_info().logical_type(), self.schema.get_basic_info().converted_type()) {
(Some(LogicalType::STRING(_)), _) => Ok(DataType::Utf8),
Expand Down

0 comments on commit 5f16f92

Please sign in to comment.