minor: remove useless mut (#4443)

apache · Jun 22, 2023 · 4b6c4d2 · 4b6c4d2
1 parent 0bcf200
commit 4b6c4d2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/arrow-buffer/src/util/bit_util.rs b/arrow-buffer/src/util/bit_util.rs
@@ -278,7 +278,7 @@ mod tests {
     }
 
     #[test]
-    #[cfg(all(any(target_arch = "x86", target_arch = "x86_64")))]
+    #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
     fn test_ceil() {
         assert_eq!(ceil(0, 1), 0);
         assert_eq!(ceil(1, 1), 1);

diff --git a/arrow-select/src/take.rs b/arrow-select/src/take.rs
@@ -30,7 +30,7 @@ use arrow_buffer::{
 use arrow_data::{ArrayData, ArrayDataBuilder};
 use arrow_schema::{ArrowError, DataType, FieldRef};
 
-use num::Zero;
+use num::{One, Zero};
 
 /// Take elements by index from [Array], creating a new [Array] from those indexes.
 ///
@@ -623,7 +623,7 @@ fn take_value_indices_from_list<IndexType, OffsetType>(
 where
     IndexType: ArrowPrimitiveType,
     OffsetType: ArrowPrimitiveType,
-    OffsetType::Native: OffsetSizeTrait + std::ops::Add + num::Zero + num::One,
+    OffsetType::Native: OffsetSizeTrait + std::ops::Add + Zero + One,
     PrimitiveArray<OffsetType>: From<Vec<OffsetType::Native>>,
 {
     // TODO: benchmark this function, there might be a faster unsafe alternative
@@ -656,7 +656,7 @@ where
             // if start == end, this slot is empty
             while curr < end {
                 values.push(curr);
-                curr += num::One::one();
+                curr += One::one();
             }
             if !list.is_valid(ix) {
                 bit_util::unset_bit(null_slice, i);

diff --git a/parquet/src/schema/types.rs b/parquet/src/schema/types.rs
@@ -2085,7 +2085,7 @@ mod tests {
         let expected_schema = parse_message_type(message_type).unwrap();
         let mut thrift_schema = to_thrift(&expected_schema).unwrap();
         // Change all of None to Some(0)
-        for mut elem in &mut thrift_schema[..] {
+        for elem in &mut thrift_schema[..] {
             if elem.num_children.is_none() {
                 elem.num_children = Some(0);
             }