Validate decimal256 with i256 directly (#3025)

* Validate decimal256 with i256 * Use from_le_bytes * Trigger Build
apache · Nov 6, 2022 · 488eff0 · 488eff0
1 parent 53b7f64
commit 488eff0
Show file tree

Hide file tree

Showing 2 changed files with 319 additions and 366 deletions.
diff --git a/arrow-array/src/types.rs b/arrow-array/src/types.rs
@@ -22,9 +22,9 @@ use crate::delta::shift_months;
 use crate::OffsetSizeTrait;
 use arrow_buffer::i256;
 use arrow_data::decimal::{
-    validate_decimal256_precision_with_lt_bytes, validate_decimal_precision,
-    DECIMAL128_MAX_PRECISION, DECIMAL128_MAX_SCALE, DECIMAL256_MAX_PRECISION,
-    DECIMAL256_MAX_SCALE, DECIMAL_DEFAULT_SCALE,
+    validate_decimal256_precision, validate_decimal_precision, DECIMAL128_MAX_PRECISION,
+    DECIMAL128_MAX_SCALE, DECIMAL256_MAX_PRECISION, DECIMAL256_MAX_SCALE,
+    DECIMAL_DEFAULT_SCALE,
 };
 use arrow_schema::{ArrowError, DataType, IntervalUnit, TimeUnit};
 use chrono::{Duration, NaiveDate};
@@ -554,7 +554,7 @@ impl DecimalType for Decimal256Type {
     }
 
     fn validate_decimal_precision(num: i256, precision: u8) -> Result<(), ArrowError> {
-        validate_decimal256_precision_with_lt_bytes(&num.to_le_bytes(), precision)
+        validate_decimal256_precision(num, precision)
     }
 }