Skip to content

Commit

Permalink
fix: Force static library build on Windows when building with Meson (#…
Browse files Browse the repository at this point in the history
…496)

May not necessarily fix
#495 but reasonably
defers trying to solve
  • Loading branch information
WillAyd authored May 29, 2024
1 parent 8894ebf commit 8171104
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions src/nanoarrow/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,24 @@ configure_file(input: 'nanoarrow_config.h.in',
output: 'nanoarrow_config.h',
configuration: conf_data)

nanoarrow_lib = library(
# Windows shared libraries are not exporting the right symbols
# See https://github.com/mesonbuild/wrapdb/pull/1536#issuecomment-2136011408
# and https://github.com/apache/arrow-nanoarrow/issues/495
if host_machine.system() == 'windows'
libtype = 'static_library'
else
libtype = 'library'
endif

nanoarrow_lib = build_target(
'nanoarrow',
'array.c',
'schema.c',
'array_stream.c',
'utils.c',
install: true)
install: true,
target_type: libtype,
)

curdir = include_directories('.') # only needed when used as subproject?
incdir = include_directories('..')
Expand Down

0 comments on commit 8171104

Please sign in to comment.