Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-7: Add macOS, Windows CI #432

Merged
merged 10 commits into from
Nov 29, 2024
Merged

GH-7: Add macOS, Windows CI #432

merged 10 commits into from
Nov 29, 2024

Conversation

lidavidm
Copy link
Member

Fixes #7.
Fixes #8.

@lidavidm
Copy link
Member Author

Hmm, macOS realpath is not as capable

@lidavidm lidavidm marked this pull request as ready for review November 28, 2024 03:12
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing but all the rest looks good to me

.github/workflows/test.yml Outdated Show resolved Hide resolved
- arch: AArch64
jdk: 11
macos: latest
include:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I missed that :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, tests all pass

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 8f8c62f into apache:main Nov 29, 2024
8 checks passed
@lidavidm lidavidm deleted the gh-7 branch November 29, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test CI: Windows Add test CI: macOS
3 participants