Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(c/driver/postgresql): don't unnecessarily COMMIT #2412

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix(c/driver/postgresql): don't unnecessarily COMMIT #2412

merged 1 commit into from
Jan 7, 2025

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Jan 6, 2025

Fixes #2410.

@lidavidm lidavidm marked this pull request as ready for review January 6, 2025 06:41
@lidavidm lidavidm requested a review from zeroshade as a code owner January 6, 2025 06:41
@github-actions github-actions bot modified the milestone: ADBC Libraries 16 Jan 6, 2025
WillAyd
WillAyd approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for the fix

paleolimbot
paleolimbot approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this (and apologies if I'm the one that introduced it! 😬 )

@lidavidm lidavidm merged commit 5536325 into apache:main Jan 7, 2025
68 checks passed
@lidavidm lidavidm deleted the gh-2410 branch January 7, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleolimbot paleolimbot paleolimbot approved these changes

@WillAyd WillAyd WillAyd approved these changes

@zeroshade zeroshade Awaiting requested review from zeroshade zeroshade is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 16
Development

Successfully merging this pull request may close these issues.

c/driver/postgresql Writing timezone-aware types causes connection leave a transaction
3 participants
@lidavidm @WillAyd @paleolimbot