Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csharp/src/Drivers/Apache): Add support for Impala ADBC Driver with Refactoring and Unit Tests #2365

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

kushaman
Copy link

  1. Added support for the Impala ADBC driver with both standard and HTTP transport protocols.
  2. Refactored the existing Spark and Impala code to move common functionalities into a shared HiveServer2.
  3. Updated Spark unit tests to align with shared functionalities for Impala and Spark.
  4. Added new unit tests for Impala ADBC driver support.

@davidhcoe
Copy link
Contributor

The Spark and Impala tests are passing for me. Can we get this closed out by early next week @CurtHagenlocher ?

@lidavidm lidavidm removed this from the ADBC Libraries 16 milestone Dec 26, 2024
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work! I've left a bunch of feedback.

csharp/test/Drivers/Apache/Impala/Resources/ImpalaData.sql Outdated Show resolved Hide resolved
csharp/test/Drivers/Apache/Impala/StatementTests.cs Outdated Show resolved Hide resolved
csharp/test/Drivers/Apache/Common/DriverTests.cs Outdated Show resolved Hide resolved
csharp/src/Drivers/Apache/Hive2/HiveServer2Connection.cs Outdated Show resolved Hide resolved
csharp/src/Drivers/Apache/Impala/ImpalaDatabase.cs Outdated Show resolved Hide resolved
csharp/src/Drivers/Apache/Impala/ImpalaHttpConnection.cs Outdated Show resolved Hide resolved
csharp/src/Drivers/Apache/Impala/ImpalaHttpConnection.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot added this to the ADBC Libraries 17 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants