fix(csharp/src/Drivers/Apache): correctly handle empty response and add Client tests #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birschick-bq
requested review from
lidavidm and
CurtHagenlocher
as code owners
birschick-bq
changed the title
CurtHagenlocher
requested changes
Oct 25, 2024
| "INTERVAL 178956969 YEAR 11 MONTH as interval, " + | ||
| "ARRAY(1, 2, 3) as numbers, " + | ||
| "STRUCT('John Doe' as name, 30 as age) as person," + | ||
| "MAP('name', CAST('Jane Doe' AS STRING), 'age', CAST(29 AS INT)) as map", |
There was a problem hiding this comment.
Is this conversion happening in ADBC code or does it come that way from the server?
| if ((_statement.BatchSize > 0 && fetchedRows < _statement.BatchSize) || fetchedRows == 0) | ||
| int columnCount = GetColumnCount(response); | ||
| int rowCount = GetRowCount(response, columnCount); ; | ||
| if ((_statement.BatchSize > 0 && rowCount < _statement.BatchSize) || rowCount == 0) |
There was a problem hiding this comment.
We can't reliably get "last batch" information from TFetchResultsResp.HasMoreRows?
There was a problem hiding this comment.
For the servers I tested, Apache Spark is setting TFetchResultsResp.HasMoreRows to false on the first and any subsequent response. I used this code as an example: https://impala.apache.org/doc/html/simba_8cc_source.html
CurtHagenlocher
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AdbcDataReader's Read method should return false in case of empty data source table. #2233