Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csharp/src/Drivers): introduce Interop.FlightSql driver #2214

Merged
merged 42 commits into from
Dec 4, 2024

Conversation

davidhcoe
Copy link
Contributor

@davidhcoe davidhcoe commented Oct 2, 2024

  • Introduces the Interop.FlightSql driver to use the FlightSQL Go driver from C#
  • Adds support for testing against multiple FlightSQL environments simultaneously in the configuration (something we may want to carry forward to other projects)
  • Has a first set of test sample data specific to Dremio, DuckDB and SQLite using https://github.com/voltrondata/SQLFlite as the server(s).
  • Adds support for the IntervalType in a generic capacity

@davidhcoe davidhcoe marked this pull request as draft October 3, 2024 13:58
@davidhcoe davidhcoe marked this pull request as ready for review October 3, 2024 17:47
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to make the process of creating something to load the driver and wrap it more generic so that potential future drivers don't require as much boiler plate as this appears to?

Otherwise, this looks pretty fine to me but I'm not very experienced with C#

@zeroshade
Copy link
Member

Like a base class that https://github.com/apache/arrow-adbc/blob/7fc08cce7404b000c400e00f208ded6dc80f6bb8/csharp/src/Drivers/Interop/FlightSql/FlightSqlDriverLoader.cs could implement?

Exactly

@davidhcoe davidhcoe marked this pull request as draft November 21, 2024 03:02
@davidhcoe
Copy link
Contributor Author

Is there any way to make the process of creating something to load the driver and wrap it more generic so that potential future drivers don't require as much boiler plate as this appears to?

Otherwise, this looks pretty fine to me but I'm not very experienced with C#

I added this in a recent push.

@davidhcoe davidhcoe marked this pull request as ready for review December 2, 2024 17:23
@davidhcoe
Copy link
Contributor Author

@CurtHagenlocher
Copy link
Contributor

@davidhcoe Can you please resolve the build conflicts?

@davidhcoe
Copy link
Contributor Author

@davidhcoe Can you please resolve the build conflicts?

ready now

@CurtHagenlocher CurtHagenlocher merged commit 08ac053 into apache:main Dec 4, 2024
6 checks passed
@davidhcoe davidhcoe deleted the dev/go-flight-sql-interop branch December 4, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants