feat(go/adbc/drivermgr): Implement GetObjects for CGO Wrapper #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
10 tasks
zeroshade
requested changes
Nov 14, 2023
Sure thing, just added them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add implementation for
GetObjectsin CGO wrapper foradbc_driver_managerWhy?
Functionality exists in C++ driver manager but not yet accessible via Go driver interface.
Notes
I haven't worked with CGO before so I wanted to limit the scope of this PR to just one of the unimplemented methods in the wrapper. I would like to continue implementing the other methods once I know I'm going about this correctly.
Closes part of #1291