-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(python): Add CMake build target for python #1257
Conversation
What's the goal here? I was intentionally trying to keep cmake out of the Python toolchain |
Ah ok thanks for the context. Happy to close then if there's not an appetite for it, I just figured it was a more convenient way to build the python libraries, which guarantees the shared libraries / targets are always up to date |
I think having this as an alternative to the pip-and-env-var workflow is fine! The conda packages do depend on the pip workflow, though (they don't bundle the libraries with the Python package, instead relying on Conda dependencies to do the work) |
Ah OK thanks - that helps better frame some of the things in CI I wasn't sure of. Will take a few more passes at this |
Current approach is less invasive - just builds on top of the environment setting in place. A bit surprised by the typing errors - need to debug that further |
Don't think CI failure is related - seen on other PRs |
Filed #1333 I will try to review this but my bandwidth for OSS is limited for the near future, unfortunately |
Sounds good. As always there is no rush on these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.