test(csharp/test/Drivers/Snowflake): Correct catalog field name in README, generify expected table name in CanClientExecuteUpdateUsingExecuteReader test #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ientExecuteUpdateUsingExecuteReader
|
|
vleslief-ms
changed the title
vleslief-ms
added a commit
to vleslief-ms/arrow-adbc
that referenced
this pull request
Nov 9, 2023
…ADME, generify expected table name in CanClientExecuteUpdateUsingExecuteReader test (apache#1240) README currently lists the field name as "database", when it should be "catalog". Also add a few small notes that the config file is JSON and there's a template in resources to use. CanClientExecuteUpdateUsingExecuteReader() currently has the table name ADBC_ALLTYPES hardcoded, ignoring the table value set in the configuration. It can be made to use the config table name instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README currently lists the field name as "database", when it should be "catalog". Also add a few small notes that the config file is JSON and there's a template in resources to use.
CanClientExecuteUpdateUsingExecuteReader() currently has the table name ADBC_ALLTYPES hardcoded, ignoring the table value set in the configuration. It can be made to use the config table name instead.