Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c/driver/postgresql: Fix C++17 usage in connection.cc #842

Closed
paleolimbot opened this issue Jun 23, 2023 · 0 comments · Fixed by #844
Closed

c/driver/postgresql: Fix C++17 usage in connection.cc #842

paleolimbot opened this issue Jun 23, 2023 · 0 comments · Fixed by #844
Assignees
@lidavidm
Milestone
ADBC Libraries 0.6.0

Comments

@paleolimbot
Copy link
Member

Noticed when recompiling the R package:

connection.cc:378:13: warning: 'if' initialization statements are a C++17 extension [-Wc++17-extensions]
        if (auto search = kPgTableTypes.find(table_type_str);
            ^
@lidavidm lidavidm added this to the ADBC Libraries 0.6.0 milestone Jun 23, 2023
@lidavidm lidavidm self-assigned this Jun 23, 2023
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Jun 23, 2023
@lidavidm
build(c): force C++11 for drivers for R's sake
c38c6b6 
Fixes apache#815.
Fixes apache#842.
@lidavidm lidavidm mentioned this issue Jun 23, 2023
Merged
lidavidm added a commit that referenced this issue Jun 24, 2023
@lidavidm
build(c): force C++11 for drivers for R's sake (#844)
518f21d 
Fixes #815.
Fixes #842.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.6.0
Development

Successfully merging a pull request may close this issue.

build(c): force C++11 for drivers for R's sake lidavidm/arrow-adbc
2 participants
@lidavidm @paleolimbot