You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
...but I didn't expect it given the symmetry with getting bytes options and commitment to communicating the final size. Was it the intention that the null-terminator is included in the output size?
The text was updated successfully, but these errors were encountered:
/// to by value. If there is sufficient space, the driver will copy
/// the option value (including the null terminator) to buffer and set
Because C strings expect null terminators so it's generally easier to just make sure it's there (like how std::string technically wouldn't need one because it tracks the length, but for interoperability it still tracks a null terminator anyways)
First noted here: #1129 (comment)
It seems like this is intentional: https://github.com/apache/arrow-adbc/blob/main/c/driver/postgresql/connection.cc#L772-L776
...but I didn't expect it given the symmetry with getting bytes options and commitment to communicating the final size. Was it the intention that the null-terminator is included in the output size?
The text was updated successfully, but these errors were encountered: