Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: diagrams aren't rendered properly #1217

Closed
lidavidm opened this issue Oct 23, 2023 · 0 comments · Fixed by #1234
Closed

docs: diagrams aren't rendered properly #1217

lidavidm opened this issue Oct 23, 2023 · 0 comments · Fixed by #1234
Assignees
@lidavidm
Milestone
ADBC Libraries 0.8.0

Comments

@lidavidm
Copy link
Member

I think this was due to the change to pre-render the Mermaid diagrams to avoid the page jumping around when loading

I think I will just manually render them (and perhaps check in a Makefile and/or pre-commit hook) and drop the dependency on sphinxcontrib-mermaid
@lidavidm lidavidm added this to the ADBC Libraries 0.8.0 milestone Oct 23, 2023
@lidavidm lidavidm self-assigned this Oct 23, 2023
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Oct 30, 2023
@lidavidm
docs: pre-render Mermaid diagrams
86bec57 
Fixes apache#1217.
@lidavidm lidavidm mentioned this issue Oct 30, 2023
Merged
lidavidm added a commit that referenced this issue Oct 30, 2023
@lidavidm
docs: pre-render Mermaid diagrams (#1234)
1b56409 
Fixes #1217.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.8.0
Development

Successfully merging a pull request may close this issue.

docs: pre-render Mermaid diagrams lidavidm/arrow-adbc
1 participant
@lidavidm